C24_WMDE_Desktop_EN_02 (round 1) #572
Open
+1,173
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
force-pushed
the
C24_WMDE_Desktop_EN_02
branch
2 times, most recently
from
5468923
to
7fbbf05
Compare
moiikana
force-pushed
the
C24_WMDE_Desktop_EN_02
branch
3 times, most recently
from
064cf74
to
8aeef94
Compare
Abban
approved these changes
Oct 16, 2024
| @@ -0,0 +1,57 @@ | |||
| // This is the file where we import the theme-specific component styles | |||
| @use 'src/themes/Treedip/swatches/skin_vector-2022' with ( | |||
There was a problem hiding this comment.
When #579 is merged the payment icons here will break. You should be able to add $select-group-image-label: true, to the list already to stop that.
- based on en 01 - Change start date to 241015 Ticket: https://phabricator.wikimedia.org/T374101
- base on EN01 ctrl https://phabricator.wikimedia.org/T374101
moiikana
force-pushed
the
C24_WMDE_Desktop_EN_02
branch
from
8aeef94
to
8a6bc9c
Compare
|
rebased main for "is late progress" feature |
3 tasks
- text change - add style support for the change in #579 https://phabricator.wikimedia.org/T374101
moiikana
force-pushed
the
C24_WMDE_Desktop_EN_02
branch
from
8a6bc9c
to
4ac7c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on en 01
var: text change
round 1, went live on 15th of October
round 2 of this banner: C24_WMDE_Desktop_EN_02b (round2) #582
Ticket: https://phabricator.wikimedia.org/T374101